Re: nvda/next af44c1d4: incubates #6860

classic Classic list List threaded Threaded
7 messages Options
Reply | Threaded
Open this post in threaded view
|

Re: nvda/next af44c1d4: incubates #6860

星空

---原始邮件---
From:"NV Access Git"<[hidden email]>;
Date:2017年2月23日(星期四) 晚上11:19
To:"nvda-commits"<[hidden email]>;
Subject:nvda/next af44c1d4: incubates #6860

commit 258dc82cce79ca77dcd9d59472fca9c40b080fac

Author: Reef Turner <[hidden email]>

Date: Tue 24 Jan 2017 17:27:32 +0800

Support for aria-current in focus mode for chrome

Raw diff

commit 7c413163d4ff5753fa17f70acb7df077a35ca8c4

Author: Reef Turner <[hidden email]>

Date: Wed 25 Jan 2017 19:45:50 +0800

Support for aria-current in focus mode for IE11

Raw diff

commit 0b23b86cef2bd64e443e3c43a50d76f232a08d62

Author: Reef Turner <[hidden email]>

Date: Wed 25 Jan 2017 22:24:32 +0800

Add support for aria-current in focus mode to Edge

Raw diff

commit 75c28c6772e5ad235ce2b9c0a6223f86c65ffc13

Author: Reef Turner <[hidden email]>

Date: Fri 27 Jan 2017 15:49:13 +0800

Added support for aria-current values with edge

While in focus mode, we can now get the values for aria-current rather
than just the presence of the property.

Raw diff

commit 8ff0d42e9ca8a199e7cb90655be797829bc8a8d1

Author: Reef Turner <[hidden email]>

Date: Mon 06 Feb 2017 13:56:46 +0000

aria current working in IE while in browse mode

Raw diff

commit 248e278d12ef4a7e823a7300edcf8a046b7c1cba

Author: Reef Turner <[hidden email]>

Date: Wed 08 Feb 2017 06:44:32 +0000

Aria-current now reported in browse mode for Edge

Raw diff

commit 43bc53499056535ececc17f30fa1dc196473c750

Author: Reef Turner <[hidden email]>

Date: Wed 08 Feb 2017 09:32:02 +0000

Support other values of aria-current

Raw diff

commit 9a7987a0957f77c6c973fe8a22546b57dbc12953

Author: Reef Turner <[hidden email]>

Date: Wed 22 Feb 2017 13:45:05 +0100

Review actions for #6860

- ensure that aria-current is output to braille.
- make `getValueForAriaCurrent` a property called isCurrent
- use a compiled regex
- simplify `if` statement
- move text labels for 'aria-current' values to a dictionary and
translate
- handle aria-current in list items and tables

Raw diff

commit 9be84bd4ebf49fbd9d2f5c441301e2a685408c52

Author: Reef Turner <[hidden email]>

Date: Thu 23 Feb 2017 16:06:13 +0100

Further review actions for #6860

Raw diff

commit af44c1d4b68c60840926d37535863f893e7b622a

Author: Reef Turner <[hidden email]>

Date: Thu 23 Feb 2017 16:07:34 +0100

incubates #6860

Incubate PR #6860 to fix issue #6358
Merge branch 'i6358-supportAriaCurrent' into next

Raw diff
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, SlashDot.org! http://sdm.link/slashdot
_______________________________________________
Nvda-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/nvda-devel

Reply | Threaded
Open this post in threaded view
|

Re: nvda/next af44c1d4: incubates #6860

Brian's Mail list account BY


Dodgy very dodgy...
 Brian
[hidden email]
Sent via blueyonder.
Please address personal email to:-
[hidden email], putting 'Brian Gaff'
in the display name field.
----- Original Message -----
From: "星空" <[hidden email]>
To: "nvda-devel" <[hidden email]>; "nvda-commits"
<[hidden email]>
Sent: Thursday, February 23, 2017 10:43 PM
Subject: Re: [Nvda-devel] nvda/next af44c1d4: incubates #6860


> ---原始邮件---
> From:"NV Access Git"<[hidden email]>;
> Date:2017年2月23日(星期四) 晚上11:19
> To:"nvda-commits"<[hidden email]>;
> Subject:nvda/next af44c1d4: incubates #6860
>
>
> commit 258dc82cce79ca77dcd9d59472fca9c40b080fac
>
> Author: Reef Turner <[hidden email]>
>
> Date: Tue 24 Jan 2017 17:27:32 +0800
>

------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, SlashDot.org! http://sdm.link/slashdot
_______________________________________________
Nvda-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/nvda-devel
Reply | Threaded
Open this post in threaded view
|

Re: nvda/next af44c1d4: incubates #6860

Reef Turner
Whats's dodgy? Is there something I have missed with this?

On Fri, Feb 24, 2017 at 11:48 AM, Brian's Mail list account BY <[hidden email]> wrote:


Dodgy very dodgy...
 Brian
[hidden email]
Sent via blueyonder.
Please address personal email to:-
[hidden email], putting 'Brian Gaff'
in the display name field.
----- Original Message -----
From: "星空" <[hidden email]>
To: "nvda-devel" <[hidden email]>; "nvda-commits"
<[hidden email]>
Sent: Thursday, February 23, 2017 10:43 PM
Subject: Re: [Nvda-devel] nvda/next af44c1d4: incubates #6860


> ---原始邮件---
> From:"NV Access Git"<[hidden email]>;
> Date:2017年2月23日(星期四) 晚上11:19
> To:"nvda-commits"<[hidden email]>;
> Subject:nvda/next af44c1d4: incubates #6860
>
>
> commit 258dc82cce79ca77dcd9d59472fca9c40b080fac
>
> Author: Reef Turner <[hidden email]>
>
> Date: Tue 24 Jan 2017 17:27:32 +0800
>

------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, SlashDot.org! http://sdm.link/slashdot
_______________________________________________
Nvda-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/nvda-devel



--
Regards,
Reef Turner

------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, SlashDot.org! http://sdm.link/slashdot
_______________________________________________
Nvda-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/nvda-devel
Reply | Threaded
Open this post in threaded view
|

Re: nvda/next af44c1d4: incubates #6860

derek riemer
I would guess he's talking about the random Chinese which came across, replied to that commit. IMHO, I don't think that was the nicest way to address that though.

On Fri, Feb 24, 2017 at 4:00 AM, Reef Turner <[hidden email]> wrote:
Whats's dodgy? Is there something I have missed with this?

On Fri, Feb 24, 2017 at 11:48 AM, Brian's Mail list account BY <[hidden email]> wrote:


Dodgy very dodgy...
 Brian
[hidden email]
Sent via blueyonder.
Please address personal email to:-
[hidden email], putting 'Brian Gaff'
in the display name field.
----- Original Message -----
From: "星空" <[hidden email]>
To: "nvda-devel" <[hidden email]>; "nvda-commits"
<[hidden email]>
Sent: Thursday, February 23, 2017 10:43 PM
Subject: Re: [Nvda-devel] nvda/next af44c1d4: incubates #6860


> ---原始邮件---
> From:"NV Access Git"<[hidden email]>;
> Date:2017年2月23日(星期四) 晚上11:19
> To:"nvda-commits"<[hidden email]>;
> Subject:nvda/next af44c1d4: incubates #6860
>
>
> commit 258dc82cce79ca77dcd9d59472fca9c40b080fac
>
> Author: Reef Turner <[hidden email]>
>
> Date: Tue 24 Jan 2017 17:27:32 +0800
>

------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, SlashDot.org! http://sdm.link/slashdot
_______________________________________________
Nvda-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/nvda-devel



--
Regards,
Reef Turner

------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, SlashDot.org! http://sdm.link/slashdot
_______________________________________________
Nvda-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/nvda-devel




--

Derek Riemer: Improving the world one byte at a time!

  • University of Colorado Boulder Department of computer science, 4th year undergraduate student.
  • Accessibility enthusiast.
  • Proud user of the NVDA screen reader.
  • Open source enthusiast.
  • Skier.

Personal website



------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, SlashDot.org! http://sdm.link/slashdot
_______________________________________________
Nvda-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/nvda-devel
Reply | Threaded
Open this post in threaded view
|

Re: nvda/next af44c1d4: incubates #6860

Brian Gaff Lineone downstairs
Yes I assumed it was a repost through some kind of Chinese spammer.
 It was my attempt at a joke!
 Brian

[hidden email]
Brian Gaff's other account.

----- Original Message -----
From: "Derek Riemer" <[hidden email]>
To: "NVDA screen reader development" <[hidden email]>
Sent: Friday, February 24, 2017 12:27 PM
Subject: Re: [Nvda-devel] nvda/next af44c1d4: incubates #6860


I would guess he's talking about the random Chinese which came across,
replied to that commit. IMHO, I don't think that was the nicest way to
address that though.

On Fri, Feb 24, 2017 at 4:00 AM, Reef Turner <[hidden email]> wrote:

> Whats's dodgy? Is there something I have missed with this?
>
> On Fri, Feb 24, 2017 at 11:48 AM, Brian's Mail list account BY <
> [hidden email]> wrote:
>
>>
>>
>> Dodgy very dodgy...
>>  Brian
>> [hidden email]
>> Sent via blueyonder.
>> Please address personal email to:-
>> [hidden email], putting 'Brian Gaff'
>> in the display name field.
>> ----- Original Message -----
>> From: "星空" <[hidden email]>
>> To: "nvda-devel" <[hidden email]>; "nvda-commits"
>> <[hidden email]>
>> Sent: Thursday, February 23, 2017 10:43 PM
>> Subject: Re: [Nvda-devel] nvda/next af44c1d4: incubates #6860
>>
>>
>> > ---原始邮件---
>> > From:"NV Access Git"<[hidden email]>;
>> > Date:2017年2月23日(星期四) 晚上11:19
>> > To:"nvda-commits"<[hidden email]>;
>> > Subject:nvda/next af44c1d4: incubates #6860
>> >
>> >
>> > commit 258dc82cce79ca77dcd9d59472fca9c40b080fac
>> >
>> > Author: Reef Turner <[hidden email]>
>> >
>> > Date: Tue 24 Jan 2017 17:27:32 +0800
>> >
>>
>> ------------------------------------------------------------
>> ------------------
>> Check out the vibrant tech community on one of the world's most
>> engaging tech sites, SlashDot.org! http://sdm.link/slashdot
>> _______________________________________________
>> Nvda-devel mailing list
>> [hidden email]
>> https://lists.sourceforge.net/lists/listinfo/nvda-devel
>>
>
>
>
> --
> Regards,
> Reef Turner
>
> ------------------------------------------------------------
> ------------------
> Check out the vibrant tech community on one of the world's most
> engaging tech sites, SlashDot.org! http://sdm.link/slashdot
> _______________________________________________
> Nvda-devel mailing list
> [hidden email]
> https://lists.sourceforge.net/lists/listinfo/nvda-devel
>
>


--

Derek Riemer: Improving the world one byte at a time!

   - University of Colorado Boulder Department of computer science, 4th
   year undergraduate student.
   - Accessibility enthusiast.
   - Proud user of the NVDA screen reader.
   - Open source enthusiast.
   - Skier.

Personal website <http://derekriemer.com>



--------------------------------------------------------------------------------


> ------------------------------------------------------------------------------
> Check out the vibrant tech community on one of the world's most
> engaging tech sites, SlashDot.org! http://sdm.link/slashdot


--------------------------------------------------------------------------------


> _______________________________________________
> Nvda-devel mailing list
> [hidden email]
> https://lists.sourceforge.net/lists/listinfo/nvda-devel
>


------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, SlashDot.org! http://sdm.link/slashdot
_______________________________________________
Nvda-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/nvda-devel
Reply | Threaded
Open this post in threaded view
|

Re: nvda/next af44c1d4: incubates #6860

Brian's Mail list account BY
In reply to this post by Reef Turner
I meant the bit I left in ie the chinese stuff. Was it another spam pick up
from another list sent to this  oone with the chinese as a big giveaway
perhaps?
 Brian

[hidden email]
Sent via blueyonder.
Please address personal email to:-
[hidden email], putting 'Brian Gaff'
in the display name field.
----- Original Message -----
From: "Reef Turner" <[hidden email]>
To: "NVDA screen reader development" <[hidden email]>
Sent: Friday, February 24, 2017 11:00 AM
Subject: Re: [Nvda-devel] nvda/next af44c1d4: incubates #6860


Whats's dodgy? Is there something I have missed with this?

On Fri, Feb 24, 2017 at 11:48 AM, Brian's Mail list account BY <
[hidden email]> wrote:

>
>
> Dodgy very dodgy...
>  Brian
> [hidden email]
> Sent via blueyonder.
> Please address personal email to:-
> [hidden email], putting 'Brian Gaff'
> in the display name field.
> ----- Original Message -----
> From: "星空" <[hidden email]>
> To: "nvda-devel" <[hidden email]>; "nvda-commits"
> <[hidden email]>
> Sent: Thursday, February 23, 2017 10:43 PM
> Subject: Re: [Nvda-devel] nvda/next af44c1d4: incubates #6860
>
>
> > ---原始邮件---
> > From:"NV Access Git"<[hidden email]>;
> > Date:2017年2月23日(星期四) 晚上11:19
> > To:"nvda-commits"<[hidden email]>;
> > Subject:nvda/next af44c1d4: incubates #6860
> >
> >
> > commit 258dc82cce79ca77dcd9d59472fca9c40b080fac
> >
> > Author: Reef Turner <[hidden email]>
> >
> > Date: Tue 24 Jan 2017 17:27:32 +0800
> >
>
> ------------------------------------------------------------
> ------------------
> Check out the vibrant tech community on one of the world's most
> engaging tech sites, SlashDot.org! http://sdm.link/slashdot
> _______________________________________________
> Nvda-devel mailing list
> [hidden email]
> https://lists.sourceforge.net/lists/listinfo/nvda-devel
>



--
Regards,
Reef Turner



--------------------------------------------------------------------------------


> ------------------------------------------------------------------------------
> Check out the vibrant tech community on one of the world's most
> engaging tech sites, SlashDot.org! http://sdm.link/slashdot


--------------------------------------------------------------------------------


> _______________________________________________
> Nvda-devel mailing list
> [hidden email]
> https://lists.sourceforge.net/lists/listinfo/nvda-devel
>


------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, SlashDot.org! http://sdm.link/slashdot
_______________________________________________
Nvda-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/nvda-devel
Reply | Threaded
Open this post in threaded view
|

Re: nvda/next af44c1d4: incubates #6860

Brian's Mail list account BY
In reply to this post by derek riemer
Yes as I said it looked like a post to one list had been lifted by a spammer
and sent to this one with Chinese in the message.
 Brian

[hidden email]
Sent via blueyonder.
Please address personal email to:-
[hidden email], putting 'Brian Gaff'
in the display name field.
----- Original Message -----
From: "Derek Riemer" <[hidden email]>
To: "NVDA screen reader development" <[hidden email]>
Sent: Friday, February 24, 2017 12:27 PM
Subject: Re: [Nvda-devel] nvda/next af44c1d4: incubates #6860


I would guess he's talking about the random Chinese which came across,
replied to that commit. IMHO, I don't think that was the nicest way to
address that though.

On Fri, Feb 24, 2017 at 4:00 AM, Reef Turner <[hidden email]> wrote:

> Whats's dodgy? Is there something I have missed with this?
>
> On Fri, Feb 24, 2017 at 11:48 AM, Brian's Mail list account BY <
> [hidden email]> wrote:
>
>>
>>
>> Dodgy very dodgy...
>>  Brian
>> [hidden email]
>> Sent via blueyonder.
>> Please address personal email to:-
>> [hidden email], putting 'Brian Gaff'
>> in the display name field.
>> ----- Original Message -----
>> From: "星空" <[hidden email]>
>> To: "nvda-devel" <[hidden email]>; "nvda-commits"
>> <[hidden email]>
>> Sent: Thursday, February 23, 2017 10:43 PM
>> Subject: Re: [Nvda-devel] nvda/next af44c1d4: incubates #6860
>>
>>
>> > ---原始邮件---
>> > From:"NV Access Git"<[hidden email]>;
>> > Date:2017年2月23日(星期四) 晚上11:19
>> > To:"nvda-commits"<[hidden email]>;
>> > Subject:nvda/next af44c1d4: incubates #6860
>> >
>> >
>> > commit 258dc82cce79ca77dcd9d59472fca9c40b080fac
>> >
>> > Author: Reef Turner <[hidden email]>
>> >
>> > Date: Tue 24 Jan 2017 17:27:32 +0800
>> >
>>
>> ------------------------------------------------------------
>> ------------------
>> Check out the vibrant tech community on one of the world's most
>> engaging tech sites, SlashDot.org! http://sdm.link/slashdot
>> _______________________________________________
>> Nvda-devel mailing list
>> [hidden email]
>> https://lists.sourceforge.net/lists/listinfo/nvda-devel
>>
>
>
>
> --
> Regards,
> Reef Turner
>
> ------------------------------------------------------------
> ------------------
> Check out the vibrant tech community on one of the world's most
> engaging tech sites, SlashDot.org! http://sdm.link/slashdot
> _______________________________________________
> Nvda-devel mailing list
> [hidden email]
> https://lists.sourceforge.net/lists/listinfo/nvda-devel
>
>


--

Derek Riemer: Improving the world one byte at a time!

   - University of Colorado Boulder Department of computer science, 4th
   year undergraduate student.
   - Accessibility enthusiast.
   - Proud user of the NVDA screen reader.
   - Open source enthusiast.
   - Skier.

Personal website <http://derekriemer.com>



--------------------------------------------------------------------------------


> ------------------------------------------------------------------------------
> Check out the vibrant tech community on one of the world's most
> engaging tech sites, SlashDot.org! http://sdm.link/slashdot


--------------------------------------------------------------------------------


> _______________________________________________
> Nvda-devel mailing list
> [hidden email]
> https://lists.sourceforge.net/lists/listinfo/nvda-devel
>


------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, SlashDot.org! http://sdm.link/slashdot
_______________________________________________
Nvda-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/nvda-devel