[Nvda-dev] commit r1898 - in trunk: . source/virtualBuffers

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

[Nvda-dev] commit r1898 - in trunk: . source/virtualBuffers

NVDA Subversion
Author: jteh
Date: Fri Apr 11 07:33:33 2008
New Revision: 1898

Log:
gecko_ia2 virtual buffer: The root document can receive focus when there is no focusable node. For example, activating a same page link causes the link to lose focus and if the target is not focusable, the document will receive focus instead. Therefore, don't handle focus for the document at all. The say all should be done by loadBuffer and the iframe will be spoken by focus ancestors when returning to the document.
base virtual buffer: Speak the document name and role before performing a say all.


Modified:
   trunk/   (props changed)
   trunk/source/virtualBuffers/__init__.py
   trunk/source/virtualBuffers/gecko_ia2.py

Modified: trunk/source/virtualBuffers/__init__.py
==============================================================================
--- trunk/source/virtualBuffers/__init__.py (original)
+++ trunk/source/virtualBuffers/__init__.py Fri Apr 11 07:33:33 2008
@@ -131,6 +131,7 @@
  if self.passThrough:
  self.passThrough=False
  virtualBufferHandler.reportPassThrough(self)
+ speech.speakObjectProperties(self.rootNVDAObject,name=True,role=True)
  info=self.makeTextInfo(textHandler.POSITION_FIRST)
  sayAllHandler.readText(info,sayAllHandler.CURSOR_CARET)
 

Modified: trunk/source/virtualBuffers/gecko_ia2.py
==============================================================================
--- trunk/source/virtualBuffers/gecko_ia2.py (original)
+++ trunk/source/virtualBuffers/gecko_ia2.py Fri Apr 11 07:33:33 2008
@@ -100,18 +100,9 @@
  api.setNavigatorObject(obj)
  if self.VBufHandle is None:
  return nextHandler()
- if sayAllHandler.isRunning():
- sayAllHandler.stop()
- wasSayAll=True
- else:
- wasSayAll=False
  if obj==self.rootNVDAObject:
  if self.passThrough:
  return nextHandler()
- speech.cancelSpeech()
- speech.speakObjectProperties(obj,name=True,role=True)
- info=self.makeTextInfo(textHandler.POSITION_FIRST)
- sayAllHandler.readText(info,sayAllHandler.CURSOR_CARET)
  return
  if obj.role==controlTypes.ROLE_DOCUMENT and not self.passThrough:
  return


Reply | Threaded
Open this post in threaded view
|

Re: [Nvda-dev] commit r1898 - in trunk: . source/virtualBuffers

James Teh-2
Peter, this should hopefully improve same page links. Note that the
"Skip to main content" link on www.freedomscientific.com/ is broken and
I suspect this is the case even for sighted people in Firefox. However,
other same page links should behave now. This also fixes some other
trouble spots where the document receives focus. Please let me know how
it goes.

Jamie

NVDA Subversion wrote:
> Author: jteh
> Date: Fri Apr 11 07:33:33 2008
> New Revision: 1898
>
> Log:
> gecko_ia2 virtual buffer: The root document can receive focus when there is no focusable node. For example, activating a same page link causes the link to lose focus and if the target is not focusable, the document will receive focus instead. Therefore, don't handle focus for the document at all. The say all should be done by loadBuffer and the iframe will be spoken by focus ancestors when returning to the document.
> base virtual buffer: Speak the document name and role before performing a say all.

--
James Teh
Email: [hidden email]
WWW: http://www.jantrid.net/
MSN Messenger: [hidden email]
Jabber: [hidden email]
Yahoo: jcs_teh


Reply | Threaded
Open this post in threaded view
|

Re: [Nvda-dev] commit r1898 - in trunk: . source/virtualBuffers

Peter Vágner
Hello,

James Teh  wrote:
> Peter, this should hopefully improve same page links. Note that the
> "Skip to main content" link on www.freedomscientific.com/ is broken and
> I suspect this is the case even for sighted people in Firefox. However,
> other same page links should behave now. This also fixes some other
> trouble spots where the document receives focus. Please let me know how
> it goes.
Really great. samepage links are now working as they should I think. I
haven't noticed other changes yet but what's most important I haven't
also noticed problems.

Thanks for the fix.

Peter