[NVDA-dev] [NVDA] #2606: Seika Braille, now supports old protocol

classic Classic list List threaded Threaded
6 messages Options
Reply | Threaded
Open this post in threaded view
|

[NVDA-dev] [NVDA] #2606: Seika Braille, now supports old protocol

NVDA Trac-3
#2606: Seika Braille, now supports old protocol
--------------------------+-------------------------------
  Reporter:  Ulf          |             Owner:  jteh
      Type:  enhancement  |            Status:  new
  Priority:  minor        |         Component:  Braille
   Version:  development  |  Operating system:  Windows XP
Blocked by:               |          Blocking:
--------------------------+-------------------------------
 Michel Such reports an error in my driver - the braille display of Michel
 has an older firmware version. So I add this protocol and Michel makes the
 test

--
Ticket URL: <http://www.nvda-project.org/ticket/2606>
NVDA <http://www.nvda-project.org/>
A free and open-source screen reader for Windows
Reply | Threaded
Open this post in threaded view
|

Re: [NVDA-dev] [NVDA] #2606: Seika Braille, now supports old protocol

NVDA Trac-3
#2606: Seika Braille, now supports old protocol
--------------------------------+--------------------------
        Reporter:  Ulf          |       Owner:  jteh
            Type:  enhancement  |      Status:  new
        Priority:  minor        |   Milestone:  2012.3
       Component:  Braille      |     Version:  development
      Resolution:               |    Keywords:
Operating system:  Windows XP   |  Blocked by:
        Blocking:               |
--------------------------------+--------------------------
Changes (by jteh):

 * milestone:   => 2012.3


Comment:

 I'm unclear: has Michel reported that this new driver fixes the issue?

--
Ticket URL: <http://www.nvda-project.org/ticket/2606#comment:1>
NVDA <http://www.nvda-project.org/>
A free and open-source screen reader for Windows
Reply | Threaded
Open this post in threaded view
|

Re: [NVDA-dev] [NVDA] #2606: Seika Braille, now supports old protocol

Michel Such
Hi Jamie,

Sorry I lost my password to directly answer the ticket.
Yes, the changes Ulf made did fix the problem with old Seika.


Michel Such
Le 20/08/2012 10:57, NVDA Trac a écrit :

> #2606: Seika Braille, now supports old protocol
> --------------------------------+--------------------------
>          Reporter:  Ulf          |       Owner:  jteh
>              Type:  enhancement  |      Status:  new
>          Priority:  minor        |   Milestone:  2012.3
>         Component:  Braille      |     Version:  development
>        Resolution:               |    Keywords:
> Operating system:  Windows XP   |  Blocked by:
>          Blocking:               |
> --------------------------------+--------------------------
> Changes (by jteh):
>
>   * milestone:   => 2012.3
>
>
> Comment:
>
>   I'm unclear: has Michel reported that this new driver fixes the issue?
>



Reply | Threaded
Open this post in threaded view
|

Re: [NVDA-dev] [NVDA] #2606: Seika Braille, now supports old protocol

Ulf Beckmann-2
In reply to this post by NVDA Trac-3
Hello,
> I'm unclear: has Michel reported that this new driver fixes the issue?
Yes, but this was via PM because I also contacted the Chinese manufacturer and he is not in this list.
Ulf

from Michel:
>> Hi Ulf,
>> am please to tell you that it works perfectly.
>> Display reponds fast and acurately and every command key works as expected.



Am 20.08.2012 10:57, schrieb NVDA Trac:
#2606: Seika Braille, now supports old protocol
--------------------------------+--------------------------
        Reporter:  Ulf          |       Owner:  jteh
            Type:  enhancement  |      Status:  new
        Priority:  minor        |   Milestone:  2012.3
       Component:  Braille      |     Version:  development
      Resolution:               |    Keywords:
Operating system:  Windows XP   |  Blocked by:
        Blocking:               |
--------------------------------+--------------------------
Changes (by jteh):

 * milestone:   => 2012.3


Comment:

 I'm unclear: has Michel reported that this new driver fixes the issue?


Reply | Threaded
Open this post in threaded view
|

Re: [NVDA-dev] [NVDA] #2606: Seika Braille, now supports old protocol

NVDA Trac-3
In reply to this post by NVDA Trac-3
#2606: Seika Braille, now supports old protocol
--------------------------------+--------------------------
        Reporter:  Ulf          |       Owner:  jteh
            Type:  enhancement  |      Status:  closed
        Priority:  minor        |   Milestone:  2012.3
       Component:  Braille      |     Version:  development
      Resolution:  fixed        |    Keywords:
Operating system:  Windows XP   |  Blocked by:
        Blocking:               |
--------------------------------+--------------------------
Changes (by jteh):

 * status:  new => closed
 * resolution:   => fixed


Comment:

 Committed in changeset:main,5371 with a few changes by me:
 * Commented out or changed log.info calls to log.debug. log.info should
 only be used for info relevant to users.
 * Removed unnecessary s40 variable at module level.

 Also, I just noticed that you time.sleep(0.1) after probing the display.
 Is this necessary? The .read() call will block until the timeout (0.2)
 expires, so it seems like this imposes an unnecessary delay.

--
Ticket URL: <http://www.nvda-project.org/ticket/2606#comment:2>
NVDA <http://www.nvda-project.org/>
A free and open-source screen reader for Windows
Reply | Threaded
Open this post in threaded view
|

Re: [NVDA-dev] [NVDA] #2606: Seika Braille, now supports old protocol

NVDA Trac-3
In reply to this post by NVDA Trac-3
#2606: Seika Braille, now supports old protocol
--------------------------------+--------------------------
        Reporter:  Ulf          |       Owner:  jteh
            Type:  enhancement  |      Status:  closed
        Priority:  minor        |   Milestone:  2012.3
       Component:  Braille      |     Version:  development
      Resolution:  fixed        |    Keywords:
Operating system:  Windows XP   |  Blocked by:
        Blocking:               |
--------------------------------+--------------------------

Comment (by Ulf):

 Hello, I have tested it without the sleep and it works, so I think it is
 not necessary.

--
Ticket URL: <http://www.nvda-project.org/ticket/2606#comment:3>
NVDA <http://www.nvda-project.org/>
A free and open-source screen reader for Windows